add diagnostic ack message with file name #1682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeiGlobus
added
no-news-is-good-news
khk-globus
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recently refactored diagnostic command is silent when doing the default zip option without the --verbose flag.
Too silent - if the diagnostic is quick, there is no information for the user of what happened, and the command completes with no output - may be confusing to the user 'did it work?'.
On Josh's suggestion, this PR adds a simple message acknowledging that the diagnostic was run, and what the generated filename is, see attached screenshot for the normal and --verbose outputs., compared to previous behavior.
(previously, without info)