Improve error message for errant func registration #1677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The observed behavior in the wild was that a double registration would complain (correctly), but reference `None` as the function id. Clearly not helpful. Improve the situation by referencing the cached value, but also relax the double-registration constraint slightly: if the calling code attempts to re-register the function with the _same_ id, then that's odd -- so warn about it -- but let it go. Still raise the exception for other errant registration attempts. [sc-36241]
khk-globus
requested review from
yadudoc,
chris-janidlo,
rjmello and
LeiGlobus
LeiGlobus
approved these changes
Oct 8, 2024
yadudoc
approved these changes
Oct 8, 2024
khk-globus
deleted the
sc-36241/improve_double_registration_error_message
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The observed behavior in the wild was that a double registration would complain (correctly), but reference
Noneas the function id. Clearly not helpful. Improve the situation by referencing the cached value, but also relax the double-registration constraint slightly: if the calling code attempts to re-register the function with the same id, then that's odd -- so warn about it -- but let it go. Still raise the exception for other errant registration attempts.[sc-36241]
Type of change