Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2.28.0 #1674

Merged
merged 7 commits into from
Oct 2, 2024
Merged

V2.28.0 #1674

Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion compute_endpoint/globus_compute_endpoint/version.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# single source of truth for package version,
# see https://packaging.python.org/en/latest/single_source_version/
__version__ = "2.28.0a1"
__version__ = "2.28.0"

# TODO: remove after a `globus-compute-sdk` release
# this is needed because it's imported by `globus-compute-sdk` to do the version check
Expand Down
2 changes: 1 addition & 1 deletion compute_endpoint/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
REQUIRES = [
"requests>=2.31.0,<3",
"globus-sdk", # version will be bounded by `globus-compute-sdk`
"globus-compute-sdk==2.28.0a1",
"globus-compute-sdk==2.28.0",
"globus-compute-common==0.4.1",
"globus-identity-mapping==0.3.0",
# table printing used in list-endpoints
Expand Down
2 changes: 1 addition & 1 deletion compute_sdk/globus_compute_sdk/sdk/auth/globus_app.py
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ def get_globus_app(environment: str | None = None):

# The authorization-via-web-link flow requires stdin; the user must visit
# the web link and enter generated code.
elif not sys.stdin.isatty() or sys.stdin.closed and not _is_jupyter():
elif (not sys.stdin.isatty() or sys.stdin.closed) and not _is_jupyter():
# Not technically necessary; the login flow would just die with an EOF
# during input(), but adding this message here is much more direct --
# handle the non-happy path by letting the user know precisely the issue
Expand Down
2 changes: 1 addition & 1 deletion compute_sdk/globus_compute_sdk/version.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

# single source of truth for package version,
# see https://packaging.python.org/en/latest/single_source_version/
__version__ = "2.28.0a1"
__version__ = "2.28.0"


def compare_versions(
Expand Down
6 changes: 3 additions & 3 deletions docs/changelog.rst
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@ Changelog

.. scriv-insert-here
.. _changelog-2.28.0a0:
.. _changelog-2.28.0:

globus-compute-sdk & globus-compute-endpoint v2.28.0a0
------------------------------------------------------
globus-compute-sdk & globus-compute-endpoint v2.28.0
----------------------------------------------------

New Functionality
^^^^^^^^^^^^^^^^^
Expand Down
Loading