Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old Automate Transfer AP scope from timers scope dependencies #1050

Merged
merged 4 commits into from
Nov 8, 2024

Conversation

MaxTueckeGlobus
Copy link
Contributor

sc-35400

Bugfixes

  • Removed the old Automate Transfer AP scope from timers scope dependencies.
  • Updated CURRENT_SCOPE_CONTRACT_VERSION and timers min_contract_version from 1 to 2.

Testing

  • Updated existing tests with the new scope dependencies.
  • Manual testing done:
    • With the existing timers tokens present, was able to create a new timer w/ data_access
    • With the existing timers tokens present, was able to create a new timer w/ no data_access
    • With no tokens present, was able to create a new timer w/ data_access
    • With the new timers tokens present, was able to revert and create a new timer w/ data_access (simulating a CLI downgrade)

Comment on lines -128 to +121
CURRENT_SCOPE_CONTRACT_VERSION: t.Final[int] = 1
CURRENT_SCOPE_CONTRACT_VERSION: t.Final[int] = 2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you find that this was behaviorally beneficial? I'm wondering if/how it helps, given that the current scope requirements are a subset of the prior ones (to be clear: this is not a leading question, it's a genuine inquiry on what you found).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version bump wasn't outright required for the changes to function correctly, but I decided to go with it since I felt the spirit of the story was making sure we had the “correct” solution. So even though the users' old tokens would work, they should still be forced to make the new “correct” ones.

@MaxTueckeGlobus MaxTueckeGlobus merged commit 8de1f23 into main Nov 8, 2024
32 checks passed
@MaxTueckeGlobus MaxTueckeGlobus deleted the sc-35400-timers-scope-update branch November 8, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants