add: TerraformをAtlantisで動かす場合のルール追加 #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yukin01
reviewed
Apr 16, 2024
terraform-with-atlantis.json
Outdated
| @@ -0,0 +1,56 @@ | |||
| { | |||
| "$schema": "https://docs.renovatebot.com/renovate-schema.json", | |||
| "platformAutomerge": true, | |||
terraform-with-atlantis.json
Outdated
Comment on lines
11
to
14
| "matchPackagePatterns": [ | ||
| "^app.terraform.io/gdp-sre", | ||
| "terraform-aws-modules/eks/aws" | ||
| ], |
There was a problem hiding this comment.
Suggested change
| "matchPackagePatterns": [ | |
| "^app.terraform.io/gdp-sre", | |
| "terraform-aws-modules/eks/aws" | |
| ], | |
| "matchManagers": [ | |
| "terraform" | |
| ], | |
| "matchPackagePatterns": [ | |
| "^app.terraform.io/gdp-sre" | |
| ], |
汎用的にしても良いのかなと！
terraform-with-atlantis.json
Outdated
Comment on lines
6
to
8
| "enabledManagers": [ | ||
| "terraform" | ||
| ], |
There was a problem hiding this comment.
デフォルトではほとんどの manger が有効になっていて、この設定値は「terraform 以外の manager を無効にする」という意図なのでここではなく各リポジトリで定義するべきかなと思います！
参考: https://docs.renovatebot.com/modules/manager/#enabling-experimental-managers
README.md
Outdated
| | pinGitHubActions.json | GitHub Actionsの推奨設定 | | ||
| | sre.json | SREチームの利用推奨設定 (pinGitHubActionsを内包) | | ||
| | terraform-with-atlantis.json | Atlantisで実行するTerraformの推奨設定、auto merge有効化を前提 | |
There was a problem hiding this comment.
↑の pinGitHubActions.json は公式の presets がキャメルケースなのを踏襲しているので、こちらもキャメルケースが良いかなと思います！
Suggested change
| | terraform-with-atlantis.json | Atlantisで実行するTerraformの推奨設定、auto merge有効化を前提 | | |
| | atlantisAutomerge.json | Atlantisで実行するTerraformの推奨設定、auto merge有効化を前提 | |
satoru-shibano
approved these changes
Apr 17, 2024
yukin01
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TerraformをAtlantisで動かしている場合の推奨設定ファイルを追加。
auto mergeを有効活用するための設定としています。
sre.jsonと組み合わせて使うことを想定しているため、extendsしていません。