Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Turn off require-default-props #236

Merged
merged 2 commits into from
Jun 4, 2021
Merged

fix: Turn off require-default-props #236

merged 2 commits into from
Jun 4, 2021

Conversation

rhirayamaaan
Copy link
Contributor

@rhirayamaaan rhirayamaaan commented Jun 4, 2021 •
edited
Loading

  • 以下の理由によりoffにします
    • PropTypes の利用は基本的にしていないため
    • React.FC の利用をやめる際に、このルールによって怒られるため

参考：https://www.notion.so/globisorg/React-FC-50a0c5dca41f4088b9d20e384786eb74

close: #235

@rhirayamaaan rhirayamaaan self-assigned this Jun 4, 2021
@rhirayamaaan rhirayamaaan changed the title [WIP] fix: Turn off require-default-props fix: Turn off require-default-props Jun 4, 2021
tatsushitoji
tatsushitoji approved these changes Jun 4, 2021
View reviewed changes
Copy link
Contributor

@tatsushitoji tatsushitoji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tatsushitoji tatsushitoji merged commit c339bbd into master Jun 4, 2021
@tatsushitoji tatsushitoji deleted the fix/disabled-require-default-props branch June 4, 2021 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tatsushitoji tatsushitoji tatsushitoji approved these changes

Assignees

@rhirayamaaan rhirayamaaan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

react/require-default-propsをオフにしたい
2 participants
@rhirayamaaan @tatsushitoji