Skip to content

Commit

Permalink
JAVA-212: Removed JUnit 4 dependency management and Hamcrest core ref…
Browse files Browse the repository at this point in the history
…erence.

Hamcrest core reference was a workaround for vintage support.
See hamcrest/JavaHamcrest#224 .
  • Loading branch information
garretwilson committed Aug 6, 2022
1 parent b1ff3bd commit f2890f4
Showing 1 changed file with 0 additions and 23 deletions.
23 changes: 0 additions & 23 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -171,12 +171,6 @@ such as `copy-bin`, created the output bin directory already.
<scope>test</scope>
</dependency>

<dependency>
<groupId>org.hamcrest</groupId>
<artifactId>hamcrest-core</artifactId>
<scope>test</scope>
</dependency>

<dependency>
<groupId>com.github.npathai</groupId>
<artifactId>hamcrest-optional</artifactId>
Expand Down Expand Up @@ -210,29 +204,12 @@ such as `copy-bin`, created the output bin directory already.
<version>${junit.version}</version>
</dependency>

<dependency>
<groupId>org.junit.vintage</groupId>
<artifactId>junit-vintage-engine</artifactId>
<version>${junit.version}</version>
</dependency>

<dependency>
<groupId>org.hamcrest</groupId>
<artifactId>hamcrest</artifactId>
<version>${hamcrest.version}</version>
</dependency>

<!--
This dependency was included so JUnit Vintage, i.e., Junit `4.12`, doesn't pull in the outdated version `1.3` of `hamcrest-core`.
This should be removed whenever JUnit Vintage is removed as well.
See [Hamcrest Issue #224](https://github.com/hamcrest/JavaHamcrest/issues/224).
-->
<dependency>
<groupId>org.hamcrest</groupId>
<artifactId>hamcrest-core</artifactId>
<version>${hamcrest.version}</version>
</dependency>

<dependency>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-api</artifactId>
Expand Down

0 comments on commit f2890f4

Please sign in to comment.