-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Russian locale #493
Add Russian locale #493
Conversation
"currency-label": "Независимая валюта", | ||
"date-label": "Независимая дата", | ||
"relative-time-label": "Независимое относительное время", | ||
"message-1": "Пример сообщения со смешанными числами \"{number}\", валютой \"{currency}\", датами \"{date}\", и относительным временем \"{relativeTime}\".", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@markelog, лишняя запятая перед "и" в перечислении датами \"{date}\", и относительным временем
.
The travis builds fail because of the malformed commit messages. They should start with a component name (looks like the maintainers use "Examples: "). |
Just got schooled by the @sompylasar :-), anyway, fixed |
73db388
to
0b758e8
Compare
"Пример сообщения с поддержкой множественного числа:", | ||
"{count, plural,", | ||
" one {У вас осталась одна задача}", | ||
" many {У вас осталось # задач}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You've missed the "few" class. Please refer to the table here: http://www.unicode.org/cldr/charts/latest/supplemental/language_plural_rules.html#ru
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should it be picked up by other
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, it might be. But I'd rather put in all the classes, this is an example and it should not contain ambiguities or unclear defaults.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rxaviers what is your preference?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@markelog, technically you are correct other
would pick it up.
I tend to agree with @sompylasar that it's good to make all ru
forms explicit: i.e., one
, few
, many
, other
for the clarity of the demo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Awesome, thank you @markelog. Thanks @sompylasar too. |
Btw. I also removed the "Standalone" part in the German translation. Might be worth considering to drop it in the English version as well. |
👍 will do that |
Merged into #481 |
No description provided.