Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation update for #272 feature. #433

Closed

Conversation

manrajgrover
Copy link
Contributor

Hi @rxaviers sir @jzaefferer sir,

Here is the documentation update for new #272 feature. I have added few examples explaining the use of this feature. Let me know further changes. Thank you.

| `"MMMEdhm"` | `"Mon, Nov 1, 5:55 PM"` |
| `"yMMMdhm"` | `"Nov 1, 2010, 5:55 PM"` |


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fact there are date and field parts in the same skeleton should be transparent for the end-user. Let's have your examples merged in the above table. Also, feel free to update the previous paragraph to include "(in Canonical Order)".

@rxaviers
Copy link
Member

Thanks. I left a comment.

@manrajgrover
Copy link
Contributor Author

Hi @rxaviers sir, :)

I have merged the tables and updated the description. Please review.

@rxaviers
Copy link
Member

Thanks @manrajgrover

@rxaviers rxaviers closed this in 2caa094 Jul 16, 2015
rxaviers pushed a commit that referenced this pull request Jan 17, 2016
ashensis pushed a commit to ashensis/globalize that referenced this pull request Mar 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants