Add relative time formatting

[mbirtwell]

Hi,

I wrote a couple of functions for formatting some date related things based on the cldr data.
getDay just looks up the names of days in the cldr data. (and supports the different formats that cldr supports)
formatRelativeCount formats an amount of time in a relative way. e.g. if you ask for 3 days in the past it will return 3 days ago. It tries to use words like today and tomorrow if available.

[rxaviers]

@mbirtwell, thanks for your contribution.

I will review your code soon. But, quick comments.

1. Could you read&sign our CLA?
2. Could you rewrite your formatRelativeCount according to Support relative time #205 (see also https://github.com/jquery/globalize/tree/fix-205-format-duration)?

[mbirtwell]

I've signed the CLA
I'll have a look at converting the work that I've done for formatRelativeCount in to formatDuration. It looks like #205 potentially covers a lot more functionality than I have attempted to implement. So I'll start by trying to re-organising what I've done so far as clean subset of the functionality and let you know how I get on.

[mbirtwell]

Ok I think I've got my head around most of the conversation in #205 what I propose doing is closing this pull request and creating two new ones.

One for getDay because I think that's useful as it is. Although arguably could live in cldrjs.

One for a relativeDuration function (the name is flexible), which will have the same API as my formatRelativeCount function which I think is very similar to the value + unit low level api that @ichernev is proposing. A full implementation could then be built on top of this. Unfortunately I want this api not the one that takes dates, so I'm not going to implement that.

Let me know what you think?

[rxaviers]

getDay just looks up the names of days in the cldr data

This method is very similar to .formatDate( <date>, "E" ). It's also very specific (you would end up having another method for Month names, quarter names, era names and so on). Also, it can be replaced by one line using cldrjs cldr.main([ "dates/calendars/gregorian/days/stand-alone", format, day ]);. So, I'd recommend one to either use .formatDate() or cldrjs directly on that case.

[rxaviers]

About the relative time format function, on #205 we came up with an API that has Dates as parameters (which is summarized in the description of #205). You are suggesting it should take integer values. I think we can extend our original API (that takes Dates) to accept either a Date or an integer value.

I suggest you to use our existing branch as a baseline and continue implementing from there. You could either close this PR and create a new one, or update this PR. I'm fine with either options.

If you are interested, I can rebase our existing branch to the current master (in order to get that up-to-date first). How does that sound to you?

[mbirtwell]

I had a go at merging master in your fix-205 branch earlier and got that to
the point of passing grunt. So I think I can continue from there.

I think there really is two functions here one that takes dates and on that
takes integer and units. I'd imagine the one that takes dates would be
implemented using the other but it seems to me trying to combine them makes
the interface a bit confusing.

On Thursday, 12 February 2015, Rafael Xavier de Souza <
[email protected]> wrote:

About the relative time format function, on #205
#205 we came up with an API
that has Dates as parameters (which is summarized in the description of
#205 #205). You are
suggesting it should take integer values. I think we can extend our
original API (that takes Dates) to accept either a Date or an integer value.

I suggest you to use our existing branch as a baseline and continue
implementing from there. You could either close this PR and create a new
one, or update this PR. I'm fine with either options.

If you are interested, I can rebase our existing branch to the current
master (in order to get that up-to-date first). How does that sound to you?

—
Reply to this email directly or view it on GitHub
#389 (comment).

[rxaviers]

Superseded by #395