Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ar(3.14) === "few" (expected "other") #317

Closed
eemeli opened this issue Sep 26, 2014 · 4 comments
Closed

ar(3.14) === "few" (expected "other") #317

eemeli opened this issue Sep 26, 2014 · 4 comments

Comments

@eemeli
Copy link

eemeli commented Sep 26, 2014

Follow-up to eemeli/make-plural#2

The test here is incorrect, as according to the CLDR rules pluralForm( 3.14, ar ) should be "other" rather than "few".

The incorrect passing is due to an error in CLDRPluralRuleParser, which I've submitted a fix for, here: santhoshtr/CLDRPluralRuleParser#15.

@rxaviers
Copy link
Member

Awesome @eemeli, thank you for digging into it.

@rxaviers
Copy link
Member

Fixed by 95126bf (edited)

@scottgonzalez
Copy link
Contributor

I think you closed the wrong issue.

@rxaviers
Copy link
Member

Actually, I've referenced the wrong commit sha above, which turned out to be two slides of my part (the first one was missing to reference this issue on the commit itself). Fixed it and thanks

ashensis pushed a commit to ashensis/globalize that referenced this issue Mar 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants