Skip to content

Commit

Permalink
Revise texts of PULL REQUEST and CONTRIBUTING guidelines
Browse files Browse the repository at this point in the history
  • Loading branch information
evilaliv3 committed Nov 14, 2024
1 parent 456d6a8 commit 6f1f655
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 10 deletions.
16 changes: 8 additions & 8 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
Before you submit a pull request, please make sure:
Before submitting a pull request, please ensure the following:

- [ ] The pull request should include a description of the problem you're trying to solve
- [ ] The pull request should include overview of the suggested solution
- [ ] If the pull requests changes current behavior, reasons why your solution is better.
- [ ] The proposed code should be fully functional
- [ ] The proposed code should contain tests relevant to prove is functionality
- [ ] The proposed tests should ensure significative code coverage
- [ ] All new and existing tests should pass
- [ ] The pull request adheres to the [CONTRIBUTING](https://github.com/globaleaks/globaleaks-whistleblowing-software/blob/fixed-custom-mock-language-access/CONTRIBUTING.md) guidelines.
- [ ] The pull request includes a description of the problem you're trying to solve.
- [ ] The pull request provides an overview of the suggested solution.
- [ ] The proposed code is fully functional.
- [ ] The proposed code includes relevant tests to verify its functionality.
- [ ] All new and existing tests pass successfully.
- [ ] Overall code quality and test coverage metrics are not reduced by more than 0.5%
6 changes: 4 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -77,9 +77,11 @@ Before you submit your Pull Request consider the following guidelines:

7. Run the full GlobaLeaks test suite and ensure that all tests pass.

8. Commit your changes using a descriptive commit message.
8. Ensure overall code quality and test coverage metrics are not reduced by more than 0.5%

9. In GitHub, send a pull request to `GlobaLeaks:main`.
9. Commit your changes using a descriptive commit message.

10. In GitHub, send a pull request to `devel` branch.

## <a name="donate"></a> Donations <img src="https://raw.githubusercontent.com/globaleaks/globaleaks-whistleblowing-software/stable/brand/assets/heart.svg" alt="heart icon" width="24" />
As a pure community-driven project without major corporate backing, we also welcome [donations](https://github.com/sponsors/globaleaks).
Expand Down

0 comments on commit 6f1f655

Please sign in to comment.