Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow running obfuscation-test.php from other directory #125

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

hannob
Copy link
Contributor

@hannob hannob commented Dec 1, 2023

This allows running obfuscation-test.php from the upper directory, by using relative require_once like in the other tests and passing a dir for the command collecting the example IBANs.

@globalcitizen globalcitizen merged commit ed8f5c0 into globalcitizen:master Dec 8, 2023
@globalcitizen
Copy link
Owner

Cheers. Actually it is insecure to do this, it would be better to use escapeshellarg() but this is an improvement anyway. Thanks.

@hannob
Copy link
Contributor Author

hannob commented Dec 8, 2023

Ok I can do another patch to just get rid of the shell code.

@hannob
Copy link
Contributor Author

hannob commented Dec 8, 2023

See #126

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants