Emoji reactions support, take 4 #2462

TheEssem · 2023-11-10T05:12:48Z

Replaces #1980, #2127, and #2221.

All previous commits have been merged and rebased. I've also fixed a couple of formatting issues and inconsistencies.

Let me know if there's anything missing. I hope to have this PR serve as a base for continued development of this patch.

TheEssem · 2023-11-10T05:46:52Z

I've been thinking about how showing who reacted to a post could work on the web UI; would it be better to show users like in the favorites/boosts lists in chronological order but with the emoji next to them somewhere (maybe next to the follow button?), or would it be better to have a list with separate tabs for different emojis?

Here are a couple of mockups for a potential button to view them; one option I thought of was to put a clickable smiley icon next to the boost/favorite counts (taken with upstream's Material Icons set, but probably doable with FA4):

Maybe an "info" button can go at the end of the reactions instead (though likely slightly larger than depicted here:

Plastikmensch · 2023-11-10T06:06:04Z

I've been thinking about how showing who reacted to a post could work on the web UI; would it be better to show users like in the favorites/boosts lists in chronological order but with the emoji next to them somewhere (maybe next to the follow button?), or would it be better to have a list with separate tabs for different emojis?

Here are a couple of mockups for a potential button to view them; one option I thought of was to put a clickable smiley icon next to the boost/favorite counts (taken with upstream's Material Icons set, but probably doable with FA4): Maybe an "info" button can go at the end of the reactions instead (though likely slightly larger than depicted here:

See: #2221 (comment)

Also Font Awesome will likely be removed.

MagicLike · 2023-11-10T06:33:57Z

I've been thinking about how showing who reacted to a post could work on the web UI; would it be better to show users like in the favorites/boosts lists in chronological order but with the emoji next to them somewhere (maybe next to the follow button?), or would it be better to have a list with separate tabs for different emojis?

Here are a couple of mockups for a potential button to view them; one option I thought of was to put a clickable smiley icon next to the boost/favorite counts (taken with upstream's Material Icons set, but probably doable with FA4): Maybe an "info" button can go at the end of the reactions instead (though likely slightly larger than depicted here:

See: #2221 (comment)

Also Font Awesome will likely be removed.

Wouldn't it be better for UX and general usability to do it "Misskey-Style" and show the usernames on hover? The list could be added anyway for a better mass-overview.

imdatceleste · 2023-11-10T06:38:46Z

If you do it MissKey-style (hover on mouse-over), how would you do that on mobile devices, where there is no mouse?

mkody · 2023-11-10T08:06:48Z

Misskey and derivatives use both a mouse-over for a quick peek (shows only 11 people and then a "+[n]") and have either a link in the post's menu or a tab to list again all reactions and who used it, similarly to how Discord does it.

Screenshots

Mouse-over:

Misskey's variant:

And on Firefish:

Edit: Adding an icon + a total count next to the favorites and boosts, like the first pic from Essem, is a good idea and keeps it consistent with the other interactions.

Plastikmensch · 2023-11-10T17:37:31Z

I'm still for removing modifications of the vanilla flavour.
It was frankly a naive mistake to suggest and doubles the workload of maintaining this beast.

Also this modifies locales managed by Crowdin again

TheEssem · 2023-11-10T21:44:24Z

Also this modifies locales managed by Crowdin again

Ah, apologies; I didn't realize that's why they were removed. Fixed.

jippi · 2023-11-11T00:17:28Z

app/mailers/notification_mailer.rb

@@ -6,8 +6,8 @@ class NotificationMailer < ApplicationMailer
         :routing

  before_action :process_params
-  before_action :set_status, only: [:mention, :favourite, :reblog]
-  before_action :set_account, only: [:follow, :favourite, :reblog, :follow_request]
+  before_action :set_status, only: [:mention, :favourite, :reaction, :reblog]


From a server owner cost management and email reputation perspective, sending an email per reaction could get incredibly expensive really fast.

It would be great to have an option for

roll reactions these up into 30-60min aggregate mails

a server setting to outright disable email notifications for reactions

Personally, I would use (2) on my server, simply because the cost aspect of potentially sending 100s of mails to a user is not something I'm interested in bankrolling on behalf of my users, and it can have significant email deliverability impact as well if users get spammed and never opens/interacts with them.

Reaction email notifications are disabled by default in user settings and notification emails of any type are only sent to inactive users anyways (unless a specific setting is manually enabled).

It's great its disabled by default, but I do think it would be great to have a server setting to turn it off, with no way to turn it on - I really don't want to see someone (myself included) being burned by potentially expensive transactional mails due to malice of some trolls, or some random toot going viral and burning through mail credits.

It can be quite expensive for on-demand transactional emails, and can prohibit verification mails from going out if the server admin is using a pre-paid delivery plan with X mails per month.

While the concern is understandable, this is not something this PR can or even should address.
As already stated, Mastodon rarely even sends e-mail notifications by default and most people don't enable those.
This just adds the option to receive e-mails for reactions, in line with other notifications.
Concerns about potentially burning e-mail credit should be brought up upstream, but this is pretty much a non-issue in practice.

TheEssem · 2023-11-13T03:16:24Z

Once the Material Symbols set is ported, I'm thinking that the current "plus" icon could be replaced with the set's own "Add Reaction" icon to better indicate what it's for and bring it more in line with other UI implementations.

github-actions · 2023-11-15T11:14:43Z

This pull request has merge conflicts that must be resolved before it can be merged.

github-actions · 2023-11-15T17:11:53Z

This pull request has resolved merge conflicts and is ready for review.

ShadowJonathan · 2023-11-15T21:07:52Z

@TheEssem what're the blockers for un-drafting this, atm, btw?

github-actions · 2023-11-15T21:13:11Z

This pull request has merge conflicts that must be resolved before it can be merged.

TheEssem · 2023-11-15T21:22:43Z

@TheEssem what're the blockers for un-drafting this, atm, btw?

I'm mainly just waiting for further review.

ShadowJonathan · 2023-11-15T21:23:44Z

If you mean maintainer review then I'd suggest making it non-draft, since else (fme) maintainers won't look at it

ClearlyClaire · 2023-11-15T21:34:10Z

I'm sorry I really don't have much mental bandwidth right now, and my priority is bringing glitch-soc to a more maintainable state. There's a lot I've postponed, and it's becoming a lot.

github-actions · 2023-11-17T00:58:00Z

This pull request has resolved merge conflicts and is ready for review.

lunaisnotaboy · 2023-11-21T14:40:41Z

Is this suitable for being merged into a fork?

lunaisnotaboy

LGTM

lunaisnotaboy · 2023-11-22T02:23:26Z

Running in production at michiru.me, and it works great!

This was in a previous PR. Not quite sure how it didn't carry over.

Probably worth tackling later, but for now it's not worth worrying about; some other implementations (e.g. Misskey's) look to have the same behavior anyways.

Reaction icon made by [email protected]

This was done to announcement reactions in 1b0cb3b. Might as well do it here too.

…r emoji reaction code

This prevents things from breaking with embeds.

github-actions · 2024-12-02T19:13:29Z

This pull request has resolved merge conflicts and is ready for review.

TheEssem mentioned this pull request Nov 10, 2023

Add Support for Emoji Reactions (Replaces #1980 and #2127) #2221

Closed

jippi reviewed Nov 11, 2023

View reviewed changes

github-actions bot added the rebase needed 🚧 label Nov 15, 2023

TheEssem force-pushed the feature/emoji-reactions branch from 58a54da to 1b0b4e9 Compare November 15, 2023 17:00

github-actions bot removed the rebase needed 🚧 label Nov 15, 2023

TheEssem force-pushed the feature/emoji-reactions branch from 1b0b4e9 to 4d0e0e6 Compare November 15, 2023 17:38

github-actions bot added the rebase needed 🚧 label Nov 15, 2023

TheEssem force-pushed the feature/emoji-reactions branch from 4d0e0e6 to 39ef8ca Compare November 17, 2023 00:11

github-actions bot removed the rebase needed 🚧 label Nov 17, 2023

lunaisnotaboy approved these changes Nov 21, 2023

View reviewed changes

TheEssem marked this pull request as ready for review November 22, 2023 01:26

github-actions bot added the rebase needed 🚧 label Dec 3, 2023

TheEssem and others added 27 commits December 2, 2024 12:54

Add reaction notification column settings

da105e5

This was in a previous PR. Not quite sure how it didn't carry over.

Fix rubocop complaint

a2644c2

Check for content attribute in Misskey likes

55cf1ae

Normalize emojis with variant selectors

bb01f80

Make name of like content parser function more general

73a0da4

Quick fixes

99a88c6

Move reaction normalization to API controller

1d8225c

Revert variant selector normalization

b4f9230

Probably worth tackling later, but for now it's not worth worrying about; some other implementations (e.g. Misskey's) look to have the same behavior anyways.

Update reaction emails

7e97e91

Reaction icon made by [email protected]

Simplify reactions API controller

57a4717

Refactor status reactions query

f965e0d

This was done to announcement reactions in 1b0cb3b. Might as well do it here too.

Fix rubocop lint issue

76d78f5

Purge status reactions on account delete

7b20384

Hydrate reactions on streaming API

cb2bc5a

Merge fixes

7d896c2

Fix reaction picker dropdown appearance

bef90d2

[Glitch+Emoji reactions] Use modern React context for for identity fo…

463f0b2

…r emoji reaction code

Disable reactions in detailed status view when visibleReactions is 0

e0aec3b

Turn custom emoji regexps into class level constants

ea9ca79

Add notification grouping for reactions

61db720

Fix reactions bar alignment in grouped notifications

4a29f8b

Fix reblog reactions being hydrated improperly

8e6a7b9

Fix grouped reaction notification text

5680b43

Make addReaction and removeReaction optional props

598c6fb

This prevents things from breaking with embeds.

Align mail status check with upstream

840f81c

Fix invisible reactions on detailed statuses when logged out

5b781ab

Fix status reactions not animating on hover when logged out

e58855d

TheEssem force-pushed the feature/emoji-reactions branch from 2cf6393 to e58855d Compare December 2, 2024 18:54

github-actions bot removed the rebase needed 🚧 label Dec 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Emoji reactions support, take 4 #2462

Emoji reactions support, take 4 #2462

TheEssem commented Nov 10, 2023 •

edited

Loading

TheEssem commented Nov 10, 2023

Plastikmensch commented Nov 10, 2023

MagicLike commented Nov 10, 2023

imdatceleste commented Nov 10, 2023

mkody commented Nov 10, 2023 •

edited

Loading

Plastikmensch commented Nov 10, 2023 •

edited

Loading

TheEssem commented Nov 10, 2023

jippi Nov 11, 2023

TheEssem Nov 11, 2023

jippi Nov 11, 2023

Plastikmensch Nov 11, 2023 •

edited

Loading

TheEssem commented Nov 13, 2023

github-actions bot commented Nov 15, 2023

github-actions bot commented Nov 15, 2023

ShadowJonathan commented Nov 15, 2023

github-actions bot commented Nov 15, 2023

TheEssem commented Nov 15, 2023

ShadowJonathan commented Nov 15, 2023 •

edited

Loading

ClearlyClaire commented Nov 15, 2023

github-actions bot commented Nov 17, 2023

lunaisnotaboy commented Nov 21, 2023

lunaisnotaboy left a comment

lunaisnotaboy commented Nov 22, 2023

github-actions bot commented Dec 2, 2024

Emoji reactions support, take 4 #2462

Are you sure you want to change the base?

Emoji reactions support, take 4 #2462

Conversation

TheEssem commented Nov 10, 2023 • edited Loading

TheEssem commented Nov 10, 2023

Plastikmensch commented Nov 10, 2023

MagicLike commented Nov 10, 2023

imdatceleste commented Nov 10, 2023

mkody commented Nov 10, 2023 • edited Loading

Plastikmensch commented Nov 10, 2023 • edited Loading

TheEssem commented Nov 10, 2023

jippi Nov 11, 2023

Choose a reason for hiding this comment

TheEssem Nov 11, 2023

Choose a reason for hiding this comment

jippi Nov 11, 2023

Choose a reason for hiding this comment

Plastikmensch Nov 11, 2023 • edited Loading

Choose a reason for hiding this comment

TheEssem commented Nov 13, 2023

github-actions bot commented Nov 15, 2023

github-actions bot commented Nov 15, 2023

ShadowJonathan commented Nov 15, 2023

github-actions bot commented Nov 15, 2023

TheEssem commented Nov 15, 2023

ShadowJonathan commented Nov 15, 2023 • edited Loading

ClearlyClaire commented Nov 15, 2023

github-actions bot commented Nov 17, 2023

lunaisnotaboy commented Nov 21, 2023

lunaisnotaboy left a comment

Choose a reason for hiding this comment

lunaisnotaboy commented Nov 22, 2023

github-actions bot commented Dec 2, 2024

TheEssem commented Nov 10, 2023 •

edited

Loading

mkody commented Nov 10, 2023 •

edited

Loading

Plastikmensch commented Nov 10, 2023 •

edited

Loading

Plastikmensch Nov 11, 2023 •

edited

Loading

ShadowJonathan commented Nov 15, 2023 •

edited

Loading