Fix incorrect upload size limit hint at /admin/custom_emojis/new #1763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kescherCode
changed the title
ClearlyClaire
approved these changes
May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, with glitch-soc, at the path
/admin/custom_emojis/new, with default production values, the hint for the image input will say "PNG or GIF up to 200 KB". When you upload something that's larger than 50 KB, the default local upload limit, it will say: "must be less than 50 KB". See screenshot below:Instead of reporting the issue separately, I went ahead and made this rather simple PR after testing it on my own instance beforehand.