Feature/pass args to debugger #1665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit eliminates debugger infrastructure that derived from the old partial/eval infrastructure. Instead, it passes the in-scope values as a constant to the `debugger` wire format opcode and uses it directly in the scope inspector. This will be followed up with support for accessing strict-mode lexical variables.
wycats
force-pushed
the
feature/pass-args-to-debugger
branch
from
721888c to
99d0232
Compare
|
local perf test shows no difference compared to main 🎉 |
NullVoxPopuli
approved these changes
Nov 19, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit eliminates debugger infrastructure that derived from the old partial/eval infrastructure.
Instead, it passes the in-scope values as a constant to the
debuggerwire format opcode and uses it directly in the scope inspector.This will be followed up with support for accessing strict-mode lexical variables.