Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Streamline append VM implementation and remove enums #1643

Closed
wants to merge 3 commits into from
Closed

Streamline append VM implementation and remove enums #1643

wants to merge 3 commits into from

Commits on Oct 30, 2024

  1. Streamline append VM implementation

    @wycats
    wycats committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    f9ff226 View commit details
    Browse the repository at this point in the history

  2. Remove some enums

    @wycats
    wycats committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    764160e View commit details
    Browse the repository at this point in the history

  3. Remove enums 

    Historically, many of these enums used `const enum`s, which at least had
the benefit of being compiled away at build time.

We've now moved to mostly normal `enum`s, which are both less efficient
than normal constants, and a relic of an earlier TypeScript era before
literal types.

This PR moves all enums to normal constants, and creates types for the
constant values when the code needs them.
    @wycats
    wycats committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    9f84b28 View commit details
    Browse the repository at this point in the history