[FEATURE] Adds inline if and unless keywords #1240
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Directly adds the inline versions of the
if
andunless
keywords tothe VM. It does this by adding a new
IfInline
opcode, which iscombined with a new
Not
opcode that inverst the condition in the caseof
unless
. This also allows us to remove theUnless
opcode andrewrite it in terms of the
If
opcode in general. Sinceunless
isgenerally much less common of an opcode, this shouldn't be an issue
performance-wise, and we benefit from having a simpler set of
wireformat/opcodes.