[BUGFIX] Absorb breakage in benchmark-env instead of benchmark #1220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some previous PRs made changes to the benchmark, but this made the benchmark itself incompatible with previous versions of Glimmer. This is something that is valuable to be able to test, so for now are going to keep absorbing all breakage in the benchmark-env.
pzuraq
force-pushed
the
bugfix/absorb-breakage-in-benchmark-env
branch
from
a50e276 to
40ea47f
Compare
|
Krausest will fail for this change, since the previous commit depended on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some previous PRs made changes to the benchmark, but this made the benchmark
itself incompatible with previous versions of Glimmer. This is something that
is valuable to be able to test, so for now are going to keep absorbing all
breakage in the benchmark-env.