[BUGFIX] Prevent accidental dynamic component lookup #1152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
requested changes
Sep 2, 2020
pzuraq
force-pushed
the
bugfix/prevent-dynamic-invocation
branch
from
2a8fb00 to
cdff060
Compare
lifeart
reviewed
Sep 2, 2020
|
|
||
| if (DEBUG && !isCurriedComponentDefinition(value)) { | ||
| throw new Error( | ||
| `A curried component definition. You may have accidentally done <this.dynamicComponent>, where dynamicComponent was a string instead of a curried component definition. You must use the {{component}} helper to create a component definition when invoking dynamically.` |
There was a problem hiding this comment.
is it possible to use real path / value for error?
one more use case is: (emberjs/ember.js#18686)
There was a problem hiding this comment.
Updated the error message to reference the debugLabel of the reference, which should give better context in general.
Re: the use case, that is what we are trying to prevent, and is not a valid use case in general. You should convert forward to:
There was a problem hiding this comment.
I know it not valid, my point is to have debug information pointing to such usage in case of error :)
(error may appear not only in this/@.foo invocation)
Dynamic components invoked via `{{component}}` share a codepath with
ones invoked via `<this.foo>`, and because of that currently if
`<this.foo>` is a referring to a string, it will dynamically lookup the
component. This is not expected behavior, and this PR prevents it by
using a different, more restricted opcode for these lookups.
pzuraq
force-pushed
the
bugfix/prevent-dynamic-invocation
branch
from
cdff060 to
a8b53cd
Compare
rwjblue
approved these changes
Sep 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dynamic components invoked via
{{component}}share a codepath withones invoked via
<this.foo>, and because of that currently if<this.foo>is a referring to a string, it will dynamically lookup thecomponent. This is not expected behavior, and this PR prevents it by
using a different, more restricted opcode for these lookups.
Closes #1149
Addresses emberjs/ember.js#17744