[REFACTOR] Removes AoT mode #1148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pzuraq
force-pushed
the
remove-aot-rebase
branch
from
ddbfb2c to
510c5f8
Compare
krisselden
approved these changes
Sep 2, 2020
The existing AoT mode is significantly different than the future direction that we want to go with precompiling templates. In particular, it relied on static analysis of programs at compile time, including being able to resolve all components ahead of time. With the direction we're moving with template imports, this will not be possible without a significant investment in static build tooling, so we want to focus on a solution that does not require this. This PR removes the existing AoT mode and refactors everything to assume that there is only one major mode for Glimmer apps to run in, which is effectively "JIT" mode as it exists today. We will continue to iterate on and improve JIT mode, until it can precompile and ship byte code templates like AoT mode could.
pzuraq
force-pushed
the
remove-aot-rebase
branch
from
510c5f8 to
67c2510
Compare
rwjblue
approved these changes
Sep 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing AoT mode is significantly different than the future
direction that we want to go with precompiling templates. In particular,
it relied on static analysis of programs at compile time, including
being able to resolve all components ahead of time. With the direction
we're moving with template imports, this will not be possible without a
significant investment in static build tooling, so we want to focus on a
solution that does not require this.
This PR removes the existing AoT mode and refactors everything to assume
that there is only one major mode for Glimmer apps to run in, which is
effectively "JIT" mode as it exists today. We will continue to iterate
on and improve JIT mode, until it can precompile and ship byte code
templates like AoT mode could.