Implement @glimmer/tracking/primatives/cache (see [emberjs/rfcs#615](https://github.com/emberjs/rfcs/blob/master/text/0615-autotracking-memoization.md) for details)
#1090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pzuraq
force-pushed
the
feat/adds-cache-api
branch
from
991e18b to
cfccc14
Compare
|
@pzuraq - Looks like this needs a rebase |
rwjblue
requested changes
May 11, 2020
pzuraq
force-pushed
the
feat/adds-cache-api
branch
from
cfccc14 to
d1064b3
Compare
krisselden
requested changes
May 12, 2020
There was a problem hiding this comment.
Make an exported interface CacheHandle<TResult = unknown> { __isCacheBrand: TResult } that createCache casts Cache to and getValue and isConst take.
The Cache doesn't implement this, you just cache at boundaries (you cast Cache as unknown then the CacheHandle in createCache and the CacheHandle to unknown to Cache in getValue and isConst).
This lets the implementation change independent of type consumers.
rwjblue
reviewed
May 12, 2020
pzuraq
force-pushed
the
feat/adds-cache-api
branch
2 times, most recently
from
df5733d to
d944a43
Compare
rwjblue
reviewed
May 12, 2020
pzuraq
force-pushed
the
feat/adds-cache-api
branch
from
d944a43 to
a7d181c
Compare
pzuraq
force-pushed
the
feat/adds-cache-api
branch
from
a7d181c to
01acfbe
Compare
krisselden
reviewed
May 13, 2020
rwjblue
approved these changes
May 13, 2020
krisselden
approved these changes
May 13, 2020
Adds the cache API specified in [RFC 615](https://github.com/emberjs/rfcs/blob/master/text/0615-autotracking-memoization.md). There were a few minor refactors in addition to this: - Moved `trackedData` into a separate module, since the `tracking` module was getting pretty big. - Renamed `isConst` to `isConstTagged`, since there is a naming conflict with the new `isConst` function. Given `isConstTagged` will be removed soon and is not generally much used outside of the VM, I thought it was better to prioritize the new API getting this name. - Rewrote the `memoizeTracked` implementation on top of the cache APIs. One thing worth noting is that in order to support the API `memoizeTracked` had before, `getValue` also needed to be able to accept and pass on args. This is something we'll wrap to hide when we expose this publicly in Ember/Glimmer for the time being, since that was a capability that was not added in the RFC.
pzuraq
force-pushed
the
feat/adds-cache-api
branch
from
01acfbe to
790508c
Compare
rwjblue
changed the title
cache api@glimmer/tracking/primatives/cache (see [emberjs/rfcs#615](https://github.com/emberjs/rfcs/blob/master/text/0615-autotracking-memoization.md) for details)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the cache API specified in RFC 615.
There were a few minor refactors in addition to this:
Moved
trackedDatainto a separate module, since thetrackingmodule was getting pretty big.
Renamed
isConsttoisConstTagged, since there is a naming conflictwith the new
isConstfunction. GivenisConstTaggedwill be removedsoon and is not generally much used outside of the VM, I thought it
was better to prioritize the new API getting this name.
Rewrote the
memoizeTrackedimplementation on top of the cache APIs.One thing worth noting is that in order to support the API
memoizeTrackedhad before,getValuealso needed to be able toaccept and pass on args. This is something we'll wrap to hide when we
expose this publicly in Ember/Glimmer for the time being, since that
was a capability that was not added in the RFC.