Fix key uniqueness implementation #1081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bugfix for the iteration's key uniqueness function, was passing the value in instead of the key derived from the value. Added a test that fails if keys are not correctly unique, originally we weren't testing this because IDENTITY returns the value it was passed in all cases except `null`.
|
Original Ember issue: emberjs/ember.js#18864 |
rwjblue
approved these changes
Apr 29, 2020
rwjblue
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix for the iteration's key uniqueness function, was passing the
value in instead of the key derived from the value. Added a test that
fails if keys are not correctly unique, originally we weren't testing
this because IDENTITY returns the value it was passed in all cases
except
null.