Ensure destructors run for items added to an {{#each after initial render
#1080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Original Ember issue: emberjs/ember.js#18855 |
Currently we don't properly setup the `DESTRUCTOR_STACK` on the VM before beginning the update when we add a new list item. This refactor renames the `iterate` function to replace `enterItem`, since that's where the majority of setup code exists, and renames `enterItem` to be `registerItem`, since that's the only part of the code that really differs between append and update. It also adds a test, which I ensured did fail before this update.
pzuraq
force-pushed
the
bugfix/iterable-update-item-destructors
branch
from
eb062e2 to
09f0190
Compare
rwjblue
reviewed
Apr 29, 2020
|
Looks like it was a fluke, originally it passed and linting failed, I reran and it passed. |
rwjblue
changed the title
{{#each after initial render
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we don't properly setup the
DESTRUCTOR_STACKon the VMbefore beginning the update when we add a new list item. This refactor
renames the
iteratefunction to replaceenterItem, since that'swhere the majority of setup code exists, and renames
enterItemto beregisterItem, since that's the only part of the code that reallydiffers between append and update. It also adds a test, which I ensured
did fail before this update.