Execute command inside bash instead of exec

[DCNick3]

Currently the command specified in Procfile is executed with exec, which does not seem to be in line what heroku does, as it breaks, for example, dotnetcore-buildpack (see jincod/dotnetcore-buildpack#145).

I propose to wrap the command executed in bash -c to support it:

    if [[ "$HEROKUISH_SETUIDGUID" == "false" ]]; then
        exec bash -c "$@"
    else
        exec setuidgid "$unprivileged_user" bash -c "$@"
    fi

[jrhodnik]

I ran into this issue as well. @jincod was able to make a patch to fix this but working the working directory isn't proper which breaks my apps that normally run fine on heroku, thus I must manually fix that in the app itself. See this issue comment for an example.

[josegonzalez]

I'm not sure why eval was used, so I'm hesitant to change process execution like that. @progrium do you remember why we use eval instead of bash -c here? 389a74e#diff-ccd15731721e777c0db64b6a0c8374c2c22c512b18f8ab156306c98b64ca44c5R21

[progrium]

its been almost a decade but my feeling is that it had to do with it being a weird quoting situation and not finding an alternative that properly evaluated the intended $@

On Fri, Apr 1, 2022 at 11:39 PM Jose Diaz-Gonzalez ***@***.***> wrote: I'm not sure why eval was used, so I'm hesitant to change process execution like that. @progrium <https://github.com/progrium> do you remember why we use eval instead of bash -c here? 389a74e #diff-ccd15731721e777c0db64b6a0c8374c2c22c512b18f8ab156306c98b64ca44c5R21 <389a74e#diff-ccd15731721e777c0db64b6a0c8374c2c22c512b18f8ab156306c98b64ca44c5R21> — Reply to this email directly, view it on GitHub <#698 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAAFB7WMMONSC4HVINL3D3VC7TRXANCNFSM5ECPH7UA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- Jeff Lindsay https://progrium.com