Ensuring part numbers are sequential

glenrobson · Jul 18, 2024 · fc4d1e9 · fc4d1e9
1 parent 7f8d3cb
commit fc4d1e9
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/src/main/java/edu/illinois/library/cantaloupe/cache/S3MultipartAsyncOutputStream.java b/src/main/java/edu/illinois/library/cantaloupe/cache/S3MultipartAsyncOutputStream.java
@@ -117,8 +117,7 @@ private class PartUploader implements Runnable {
         @Override
         public void run() {
             try {
-                final int partNumber = partIndex + 1;
-
+                final int partNumber = partIndex++;
                 UploadPartRequest uploadPartRequest = UploadPartRequest.builder()
                         .bucket(bucket)
                         .key(key)
@@ -229,7 +228,9 @@ public void run() {
     private boolean requestCreated;
 
     private String uploadID;
-    private int partIndex;
+    // Part number must start with 1
+    // minio will hang if this is 0
+    private int partIndex = 1;
     private long indexWithinPart;
 
     /** For an instance to wait for an upload notification during testing. */
@@ -315,7 +316,6 @@ private void uploadPartIfNecessary() {
             IOUtils.closeQuietly(currentPart);
             currentPart     = null;
             indexWithinPart = 0;
-            partIndex++;
         }
     }