Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to sass-embedded #327

Closed
5 tasks done
glenn2223 opened this issue Sep 27, 2023 · 0 comments · Fixed by #371
Closed
5 tasks done

Switch to sass-embedded #327

glenn2223 opened this issue Sep 27, 2023 · 0 comments · Fixed by #371
Labels
enhancement New feature or request
Milestone
v7

Comments

@glenn2223
Copy link
Owner

glenn2223 commented Sep 27, 2023 •
edited
Loading

Issues

The standard SASS package, combined with some VS Code weirdness, means I have to specify that I want the NodeJS version of the package.

Proposal

OLD: Use the compileString method with my own Importer utilising the built-in fs module.

NEW: Fix this issue and also use the speedier compiler

This has the added benefit of:

TODO

  • Move to the embedded SASS host
  • Move to compileStringAsync Not immediately required
    • Implement the Importer N/A
  • Possibly remove some deprecated settings (if they aren't supported) like formats[].lineFeed
  • Update docs

Related issues
@glenn2223 glenn2223 added this to the v7 milestone Sep 27, 2023
@glenn2223 glenn2223 added the enhancement New feature or request label Sep 27, 2023
@glenn2223 glenn2223 changed the title Utilise fs and SASS' compileString Switch to sass-embedded Jul 30, 2024
@glenn2223 glenn2223 mentioned this issue Jul 30, 2024
Open
5 tasks
glenn2223 added a commit that referenced this issue Sep 21, 2024
@glenn2223
SASS Embedded Host
91422ac 
### Breaking Changes

-   We have moved to the quicker `sass-embedded`. Closes [#327](#327)
    This uses the latest compiler, but drops these settings:
    -   `liveSassCompile.settings.formats[].linefeed`
    -   `liveSassCompile.settings.formats[].indentType`
    -   `liveSassCompile.settings.formats[].indentWidth`
        _Note: these 3 would've been dropped for SASS 2.0 anyway_
    -   `liveSassCompile.settings.useNewCompiler`

### Changed

-   Switched from `[email protected]` to `[email protected]` - as mentioned above

### Updated

-   `autoprefixer` to `10.4.20` [Changelog][cl:fd]
-   `fdir` to `6.3.0` [Changelog][cl:fd]
-   `picomatch` to `4.0.2` [Changelog][cl:pm]
-   `postcss` to `8.4.47` [Changelog][cl:pc]
-   Various dev dependency updates _(nothing user facing)_

[cl:ap]: https://github.com/postcss/autoprefixer/blob/main/CHANGELOG.md
[cl:fd]: https://github.com/thecodrr/fdir/releases
[cl:pc]: https://github.com/postcss/postcss/blob/main/CHANGELOG.md
[cl:pm]: https://github.com/micromatch/picomatch/blob/master/CHANGELOG.md
@glenn2223 glenn2223 mentioned this issue Sep 21, 2024
Merged
glenn2223 added a commit that referenced this issue Sep 21, 2024
@glenn2223
Switch to SASS Embedded Host (Fix: #327) - PR#371 from glenn2223
87b33f5 
### Breaking Changes

-   We have moved to the quicker `sass-embedded`. Closes [#327](#327)  
    This uses the latest compiler, but drops these settings:
    -   `liveSassCompile.settings.formats[].linefeed`
    -   `liveSassCompile.settings.formats[].indentType`
    -   `liveSassCompile.settings.formats[].indentWidth`  
        _Note: these 3 would've been dropped for SASS 2.0 anyway_
    -   `liveSassCompile.settings.useNewCompiler`

### Changed

-   Switched from `[email protected]` to `[email protected]` - as mentioned above

### Updated

-   `autoprefixer` to `10.4.20` [Changelog][cl:fd]
-   `fdir` to `6.3.0` [Changelog][cl:fd]
-   `picomatch` to `4.0.2` [Changelog][cl:pm]
-   `postcss` to `8.4.47` [Changelog][cl:pc]
-   Various dev dependency updates _(nothing user facing)_

[cl:ap]: https://github.com/postcss/autoprefixer/blob/main/CHANGELOG.md
[cl:fd]: https://github.com/thecodrr/fdir/releases
[cl:pc]: https://github.com/postcss/postcss/blob/main/CHANGELOG.md
[cl:pm]: https://github.com/micromatch/picomatch/blob/master/CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v7
Development

Successfully merging a pull request may close this issue.

Switch to SASS Embedded Host (Fix: #327) glenn2223/vscode-live-sass-compiler
1 participant
@glenn2223