Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue Report: Not compiling any .scss files in VS Code #322

Closed
brianheath opened this issue Aug 28, 2023 · 7 comments · Fixed by #339 or #340
Closed

Issue Report: Not compiling any .scss files in VS Code #322

brianheath opened this issue Aug 28, 2023 · 7 comments · Fixed by #339 or #340
Labels
info required More information is required
Milestone

Comments

@brianheath
Copy link

brianheath commented Aug 28, 2023

UNEXPECTED ERROR

Machine & Versions

Item Value
Win 10 Pro v22H2
VS Code v1.81.1
Platform win32 x64
Node 16.17.1 (110)
Live Sass 6.1.1
Installed Extensions
- vscode.css-language-features (1.0.0)
- vscode.debug-auto-launch (1.0.0)
- vscode.emmet (1.0.0)
- vscode.git (1.0.0)
- vscode.git-base (1.0.0)
- vscode.github (0.0.1)
- vscode.github-authentication (0.0.2)
- vscode.html-language-features (1.0.0)
- vscode.json-language-features (1.0.0)
- vscode.merge-conflict (1.0.0)
- vscode.microsoft-authentication (0.0.1)
- ms-vscode-remote.remote-wsl-recommender (0.0.19)
- vscode.typescript-language-features (1.0.0)
- eamodio.gitlens (14.2.1)
- glenn2223.live-sass (6.1.1)
- HookyQR.beautify (1.5.0)
- olback.es6-css-minify (3.3.3)

LOG:

{
"NO LOG": "PLEASE SPECIFY YOUR ISSUE BELOW"
}

=======================

Issue:

Nothing is compiled when updating & saving any *.scss partials or main files in VS Code.
Output messages claim the files are excluded in settings, but there are no exclusions:
The file has not been compiled as it's excluded by user settings

Steps taken:

  • Nothing has changed since (Friday?) when it was working last (AFAIK)
  • Rebooted computer
  • Disabled/Re-enabled extension
  • Uninstalled/Reinstalled extension
  • Changed/removed/added settings in settings.json file
    • Removed excludeList as well as all other liveSassCompile settings
    • Setting compileOnWatch to true does not produce any results
  • Changed to a different workspace
  • Attempted on multiple files
  • Disabled all other extensions
  • Added includeItems after the excludeList to no avail:
    "liveSassCompile.settings.includeItems": [
        "/**/scss/*.sass",
        "/**/scss/*.scss"
    ],

Details:

  • Windows 10 Pro 22H2

When saving:

VS Code event: "onDidSaveTextDocument"
--------------------
Found the workspace folder
Workspace Name: Home
--------------------
SASS file saved
A SASS file has been saved, starting checks
--------------------
Checking SASS path isn't excluded
Path: \\titan\inetSource\wwwdev\Home\css\scss\_become-a-dealer.scss
--------------------
No base folder override found. Keeping workspace folder
--------------------
Searching folder
Search results
--------------------
File not found, must be excluded
--------------------
File excluded
The file has not been compiled as it's excluded by user settings
Path: \\titan\inetSource\wwwdev\Home\css\scss\_become-a-dealer.scss
--------------------

Command called: "liveSass.command.debugInclusion"

--------------------
Checking current file
\\titan\inetSource\wwwdev\Home\css\scss\_become-a-dealer.scss
--------------------
Found the workspace folder
Workspace Name: Home
--------------------
Checking SASS path isn't excluded
Path: \\titan\inetSource\wwwdev\Home\css\scss\_become-a-dealer.scss
--------------------
No base folder override found. Keeping workspace folder
--------------------
Searching folder
Search results
--------------------
File not found, must be excluded
--------------------
File excluded
The file is excluded based on your settings, please check your configuration
--------------------

Command called: "liveSass.command.debugFileList"

--------------------
Getting SASS files
Query pattern: undefined
Can be overwritten: true
--------------------
Checking folder 1 of 1
Folder: Home
--------------------
No base folder override found. Keeping workspace folder
--------------------
Found 0 SASS files
--------------------
Getting SASS files
Query pattern: /**/_*.s[ac]ss
Can be overwritten: false
--------------------
Checking folder 1 of 1
Folder: Home
--------------------
No base folder override found. Keeping workspace folder
--------------------
Found 0 SASS files
--------------------
Getting SASS files
Query pattern: /**/node_modules/**,/**/.vscode/**,/**/includes/**
Can be overwritten: false
--------------------
Checking folder 1 of 1
Folder: Home
--------------------
No base folder override found. Keeping workspace folder
--------------------
Found 0 SASS files
--------------------
Extension Info
--------------------
Current File
--------------------
\\titan\inetSource\wwwdev\Home\css\scss\_become-a-dealer.scss
--------------------
Workspace Folders
--------------------
[0] Home
\\titan\inetSource\wwwdev\Home
--------------------
Checking workspace folder 1 of 1
Path: \\titan\inetSource\wwwdev\Home
--------------------
--------------------
Current Include/Exclude Settings
--------------------
Include: [ NULL ]
Exclude: [ /**/node_modules/**, /**/.vscode/**, /**/includes/** ]
--------------------
Included SASS Files
--------------------
--------------------
Included Partial SASS Files
--------------------
--------------------
Excluded SASS Files
--------------------
--------------------

settings.json

{
    "terminal.integrated.defaultProfile.windows": "Git Bash",
    "liveSassCompile.settings.autoprefix": [
        "> 1%",
        "last 2 versions"
    ],
    "liveSassCompile.settings.excludeList": [
        "/**/node_modules/**",
        "/**/.vscode/**",
        "/**/includes/**"
    ],
    "liveSassCompile.settings.formats": [
        {
            "format": "compressed",
            "extensionName": ".min.css",
            "savePath": "~/.."
        }
    ],
    "explorer.confirmDelete": false,
    "security.workspace.trust.untrustedFiles": "open",
    "liquid.format": true,
    "workbench.startupEditor": "none",
    "diffEditor.ignoreTrimWhitespace": false,
    "liveSassCompile.settings.showOutputWindowOn": "Trace",
    "liveSassCompile.settings.useNewCompiler": true,
    "files.associations": {
        "*.asp": "html"
    },
    "git.openRepositoryInParentFolders": "always",
    "security.allowedUNCHosts": [
        "titan"
    ],
    "liveSassCompile.settings.compileOnWatch": false,
}
@brianheath brianheath changed the title Issue Report: Not compiling any .scss files Issue Report: Not compiling any .scss files in VS Code Aug 29, 2023
@glenn2223
Copy link
Owner

Sorry for the delay.

Yeah, very strange! Like you said there wasn't a release on the Friday.

Some thoughts:

  • rollback to the one of the previous versions, in case the extension update was delayed (for some reason)
  • some users have reported issues when working on network drives - one report (here) said that shadow files were the underlying issue.
  • I assume the compilation works fine when the files are on the local machine??
  • if it's a remote development situation, I assume you have the extension installed on the server rather than the local machine?

@glenn2223 glenn2223 added the info required More information is required label Sep 1, 2023
@brianheath
Copy link
Author

Well now THAT'S interesting. This is local development but it's on the network using UNC. What's interesting is that when I map the network path to an actual drive letter, it works. But when I go back to UNC and edit the same exact file, I get that error.

Yes, it works perfectly on a local drive.

The other very odd thing about it is, I have been using UNC for 4+ years doing development here and have never had a problem (mapping a drive letter breaks our Git repo) until I wrote this issue report.

I am at a total complete loss as to why this happened all of a sudden. None of the paths have changed, and nobody uses a Mac here so there aren't any shadow or hidden files created as a result.

I also went into Git BASH and ran sass manually using the same exact UNC path and it worked just fine.

Is there any kind of setting that I can add or change in this case, to perhaps tell it to look at this complete pathway? Should I be using double back/forward slashes or anything? I'm so utterly clueless as to what to do at this point.

Thank you so much for your help.

P.S. This has been the greatest extension EVER, and I will be forever singing its praise regardless of how my situation works out!

@glenn2223
Copy link
Owner

Thanks for the info

This, and other issues, make me think I might need to move away from fdir and use VsCode's built-in watcher and filesystem. The reason is that VSCode knows the files are there and can clearly read the contents. By doing this I should be able to pass to the compiler the exact paths and contents for it to work on.

I think all this would make it a breaking change as the switch may have undue consequences (like breaking certain glob patterns). If I were to eventually get an alpha release, would you be willing to test?


Also, did you try rolling back? Just in case an update was delayed and installed later?

@glenn2223 glenn2223 added this to the v7 milestone Sep 13, 2023
@brianheath
Copy link
Author

I absolutely would be willing to test that - whatever I can do to help!

I actually did not roll back the extension itself, but I will do that to see if that changes anything.

Come to think of it now... There was something that I noticed at the time:
There was a change that made me prefix the patterns with "/" in the file exclusions & inclusions. That seems to have coincided with all of this. That makes me think you were right about the delayed update. I will do a rollback in a bit and let you know the outcome.

Thank you!

@brianheath
Copy link
Author

Okay, so to update, reverting to v6.1.0 did indeed rectify the issue. So I will continue to use this version for the time being.

Please let me know if there is anything else I can do to help. Thanks!

@Gisco246
Copy link

Came here to say i have the same Issue with network drive. also reverted back to v6.1.0 to make it work.

@glenn2223
Copy link
Owner

Turns out that fdir has fixed the issue. I will release v6.1.2 soon which should fix this issue - though the plans in #325 still stand

glenn2223 added a commit that referenced this issue Nov 22, 2023
### Fixed

-   File resolution in network drives on windows is working again; after break in v6.1.1. Closes [#323](#323)

### Updated

-   `fdir` to `6.1.1` [Changelog][cl:fd]
-   `picomatch` to `3.0.1` [Changelog][cl:pm]

[cl:fd]: https://github.com/thecodrr/fdir/releases
[cl:pm]: https://github.com/micromatch/picomatch/blob/master/CHANGELOG.md
glenn2223 added a commit that referenced this issue Nov 22, 2023
# 6.1.2 - 2023-11-22

<small>[Compare to previous release][comp:6.1.2]</small>

### Fixed

-   Fix for a network file-resolution bug introduced in v6.1.1. Closes [#322](#322)

### Updated

-   `sass` to `1.69.5` [Changelog][cl:sa]
-   `fdir` to `6.1.1` [Changelog][cl:fd]
-   `picomatch` to `3.0.1` [Changelog][cl:pm]
-   `postcss` to `8.4.31` [Changelog][cl:pc]
-   `autoprefixer` to `10.4.16` [Changelog][cl:ap]
-   Various dev dependency updates _(nothing user facing)_

[comp:6.1.2]: v6.1.1...v6.1.2
[cl:ap]: https://github.com/postcss/autoprefixer/blob/main/CHANGELOG.md
[cl:fd]: https://github.com/thecodrr/fdir/releases
[cl:pc]: https://github.com/postcss/postcss/blob/main/CHANGELOG.md
[cl:pm]: https://github.com/micromatch/picomatch/blob/master/CHANGELOG.md
[cl:sa]: https://github.com/sass/dart-sass/blob/main/CHANGELOG.md
@glenn2223 glenn2223 mentioned this issue Nov 22, 2023
glenn2223 added a commit that referenced this issue Nov 22, 2023
# 6.1.2 - 2023-11-22

<small>[Compare to previous release][comp:6.1.2]</small>

### Fixed

-   Fix for a network file-resolution bug introduced in v6.1.1. Closes [#322](#322)

### Updated

-   `sass` to `1.69.5` [Changelog][cl:sa]
-   `fdir` to `6.1.1` [Changelog][cl:fd]
-   `picomatch` to `3.0.1` [Changelog][cl:pm]
-   `postcss` to `8.4.31` [Changelog][cl:pc]
-   `autoprefixer` to `10.4.16` [Changelog][cl:ap]
-   Various dev dependency updates _(nothing user facing)_

[comp:6.1.2]: v6.1.1...v6.1.2
[cl:ap]: https://github.com/postcss/autoprefixer/blob/main/CHANGELOG.md
[cl:fd]: https://github.com/thecodrr/fdir/releases
[cl:pc]: https://github.com/postcss/postcss/blob/main/CHANGELOG.md
[cl:pm]: https://github.com/micromatch/picomatch/blob/master/CHANGELOG.md
[cl:sa]: https://github.com/sass/dart-sass/blob/main/CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
info required More information is required
Projects
None yet
3 participants