Fixed ninject/Ninject#237

ReleaseNotes.md

@@ -17,6 +17,7 @@ Version 4.0
 - Bugfix: Break Singleton / circular dependency WithPropertyValue
 - Bugfix: InSingletonScope bug when requesting an instance in OnActivation callback https://github.com/ninject/Ninject/issues/221 https://github.com/ninject/Ninject/issues/224
 - Bugfix: The invoked member is not supported in a dynamic assembly https://github.com/ninject/Ninject/issues/225
+- Bugfix: Conditional binding is not being considered when score constructors https://github.com/ninject/Ninject/issues/237
 
 Version 3.2
 ---------------

src/Ninject.Test/Integration/ConstructorSelectionTests.cs

@@ -60,6 +60,19 @@ public void FirstAvailableWithBindingAvailableIsUsed()
             barracks.Weapon.Should().NotBeNull();
         }
 
+        [Fact]
+        public void UnsatisfiedConditionalShouldBeIngored()
+        {
+            kernel.Bind<Barracks>().ToSelf();
+            kernel.Bind<IWeapon>().To<Sword>();
+            kernel.Bind<IWarrior>().To<Samurai>().When(_ => false);
+
+            var barracks = kernel.Get<Barracks>();
+            barracks.Should().NotBeNull();
+            barracks.Warrior.Should().BeNull();
+            barracks.Weapon.Should().NotBeNull();
+        }
+
         [Fact]
         public void CtorWithMostDependenciesIsUsedWhenBindingsAreAvailable()
         {

src/Ninject/Selection/Heuristics/StandardConstructorScorer.cs

@@ -108,7 +108,9 @@ protected virtual bool BindingExists(IContext context, ITarget target)
         protected virtual bool BindingExists(IReadOnlyKernel kernel, IContext context, ITarget target)
         {
             var targetType = this.GetTargetType(target);
-            return kernel.GetBindings(targetType).Any(b => !b.IsImplicit)
+            var request = context.Request.CreateChild(targetType, context, target);
+
+            return kernel.GetBindings(targetType).Any(b => !b.IsImplicit && b.Matches(request))
                    || target.HasDefaultValue;
         }