image plane priors for position #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntessore
force-pushed
the
nt/image-plane-priors
branch
2 times, most recently
from
5197a0a to
e10a873
Compare
|
Excellent! |
|
I'm a bit peeved by the fact that this was possible with so little changes. |
ntessore
force-pushed
the
nt/image-plane-priors
branch
from
1b11289 to
4f17a54
Compare
|
There is a problem with the different address spaces used for I think I have to change the storage of the |
ntessore
force-pushed
the
nt/image-plane-priors
branch
from
4f17a54 to
1e78b73
Compare
|
I have rebased this onto the proposed changes of #202 as they should take care of the problems. |
ntessore
force-pushed
the
nt/image-plane-priors
branch
from
1e78b73 to
8821190
Compare
ntessore
pushed a commit
that referenced
this pull request
Sep 23, 2015
image plane priors for position
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces image plane priors for the positions of objects. With these, it's possible to fix the position of a source to one of its visible images. This is done in the ini file by prefixing the prior with
image, for exampleThe image plane prior is calculated in the
set_paramskernel which is called when parameters need adjustment. Given how rarely that happens relative to the deflection and surface brightness calculations, there should not be any noticeable impact on performance.The implementation is restricted to objects that have subsequent parameters x and y (i.e. all of the current ones).