Support DeepL glossaries #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeepL supports creating glossaries via their API. Each glossary is created for a given locale pair and can then be used by passing its `id` to the `glossary_id` param of the `translate` API endpoint. Due to this constraint, the glossary to be used can only be defined when we know the source and target locales, thus using the `glossary_id` directly in `i18n-tasks.yml` is quite unconvenient. This commit adds a `deepl_glossary_ids` configuration entry that allows listing all glossaries that may be used for translations with DeepL as a backend. When a DeepL translation is performed, this commit adds some logic that fetches all glossaries on DeepL (they are associated with the API key) and selects one (if any) that: * is marked as `ready` by DeepL * can be used for the appropriate source locale * can be used for the appropriate target locale * is present in the `deepl_glossary_ids` configuration
|
Nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DeepL supports creating glossaries via their API. Each glossary is created for a given locale pair and can then be used by passing its
idto theglossary_idparam of thetranslateAPI endpoint.Due to this constraint, the glossary to be used can only be defined when we know the source and target locales, thus using the
glossary_iddirectly ini18n-tasks.ymlis quite unconvenient.This commit adds a
deepl_glossary_idsconfiguration entry that allows listing all glossaries that may be used for translations with DeepL as a backend.When a DeepL translation is performed, this commit adds some logic that fetches all glossaries on DeepL (they are associated with the API key) and selects one (if any) that:
readyby DeepLdeepl_glossary_idsconfiguration