DeepL: Allow formality option to be configured through config. #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeepL allows formality to be optionally more or less formal for certain languages (https://www.deepl.com/docs-api/translate-text/translate-text/). However, the DeepL gem does not allow this to be configured globally, only on a per-call basis to the `DeepL.translate` call. By adding a `deepl_options:` key to the configuration, we allow some of these keys to be overridden.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DeepL has the concept of `formality for certain languages (https://www.deepl.com/docs-api/translate-text/translate-text/).
e.g:
However, the DeepL gem does not allow this to be configured globally, only on a per-call basis to the
DeepL.translatecall. I looked, but couldn't find a way to alter this in config.By adding a
deepl_options:key to the configuration, we allow some of these keys to be overridden (although keepingextra_optionsfirst in the merge chain means that explicitly setignore_tagsremains forced).Had a look at the spec for the
DeeplTranslatorbut couldn't see an easy way to assert this - feel free to let me know where I should add the spec!