Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle multiline ERB comments #432

Merged
merged 1 commit into from
Mar 26, 2022
Merged

Handle multiline ERB comments #432

merged 1 commit into from
Mar 26, 2022

Conversation

glebm
Copy link
Owner

@glebm glebm commented Mar 26, 2022

Fixes #431

davidwessman
davidwessman approved these changes Mar 26, 2022
View reviewed changes
Copy link
Collaborator

@davidwessman davidwessman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was just getting started on this 🙂 Looking good!

@glebm glebm merged commit c2c257d into main Mar 26, 2022
@glebm glebm deleted the multiline-comments branch March 26, 2022 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidwessman davidwessman davidwessman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parser Error when erb comment tags span multiple lines
2 participants
@glebm @davidwessman