-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Yandex translator option to translate_missing functionality #343
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,61 @@ | ||
# frozen_string_literal: true | ||
|
||
require 'i18n/tasks/translators/base_translator' | ||
|
||
module I18n::Tasks::Translators | ||
class YandexTranslator < BaseTranslator | ||
def initialize(*) | ||
begin | ||
require 'yandex-translator' | ||
rescue LoadError | ||
raise ::I18n::Tasks::CommandError, "Add gem 'yandex-translator' to your Gemfile to use this command" | ||
end | ||
super | ||
end | ||
|
||
protected | ||
|
||
def translate_values(list, **options) | ||
list.map { |item| translator.translate(item, options) } | ||
end | ||
|
||
def options_for_translate_values(from:, to:, **options) | ||
options.merge( | ||
from: to_yandex_compatible_locale(from), | ||
to: to_yandex_compatible_locale(to) | ||
) | ||
end | ||
|
||
def options_for_html | ||
{} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The Yandex API needs I see that the yandex-translate gem doesn't support the Looks like there is an abandoned PR for this aegorov/yandex-translator#13 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Opened a pr to do that work over there and updated the implementation here to utilize it: |
||
end | ||
|
||
def options_for_plain | ||
{} | ||
end | ||
|
||
def no_results_error_message | ||
I18n.t('i18n_tasks.yandex_translate.errors.no_results') | ||
end | ||
|
||
private | ||
|
||
# Convert 'es-ES' to 'es' | ||
def to_yandex_compatible_locale(locale) | ||
return locale unless locale.include?('-') | ||
locale.split('-', 2).first | ||
end | ||
|
||
def translator | ||
@translator ||= Yandex::Translator.new(api_key) | ||
end | ||
|
||
def api_key | ||
@api_key ||= begin | ||
key = @i18n_tasks.translation_config[:yandex_api_key] | ||
fail ::I18n::Tasks::CommandError, I18n.t('i18n_tasks.yandex_translate.errors.no_api_key') if key.blank? | ||
key | ||
end | ||
end | ||
end | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: This is going to cause lots of requests to the Yandex API, processed in-sequence (slow).
It would be better to pass multiple
text
parameters to the request, batched to avoid hitting the 10,000 character limit, each batch in its own Thread or Fiber. This should be implemented in the yandex gem.This is not a blocker for submitting this PR (just waiting for a new release of the yandex gem).