Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README and post installation instructions message #320

Merged
merged 1 commit into from
Dec 8, 2018

Conversation

dportalesr
Copy link
Contributor

  • Recommend usage of 'bundle exec'.
  • Update post installation instructions to use bundle exec.

My enviroment couldn't find the i18n-task executable without the use of bundle exec.
Showing this recommendation in the post installation message will make this more friendly for projects using this gem.

README.md Outdated
@@ -45,7 +45,7 @@ $ cp $(i18n-tasks gem-path)/templates/minitest/i18n_test.rb test/

## Usage

Run `i18n-tasks` to get the list of all the tasks with short descriptions.
Run `i18n-tasks` or `bundle exec i18n-tasks` (recommended) to get the list of all the tasks with short descriptions.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just say bundle exec i18n-tasks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest of the document still refers running it without the bundle exec but I'm not sure if it's a good idea to replace it everywhere.

@glebm glebm merged commit 6662d80 into glebm:master Dec 8, 2018
@glebm
Copy link
Owner

glebm commented Dec 8, 2018

Thanks!

bartimaeus added a commit to bartimaeus/i18n-tasks that referenced this pull request Feb 8, 2019
* upstream/master: (177 commits)
  ✏️ Typo
  📝 Add example of usage for "Key pattern syntax"
  Silence warnings for common leaf -> tree expansion scenario.
  Update README and post installation instructions message (glebm#320)
  Bump to v0.9.28
  Do not consider a plural node if it only has one child with no count (glebm#312)
  Include file name in CommandError raised during unsuccessful file load (glebm#313)
  Use separate trees per locale in missing_plural_forest (glebm#311)
  Missing plural keys: Extract plural_nodes method
  Missing plural keys: minor optimization
  Missing plural keys: do not modify data nodes
  Check for missing plural keys (glebm#309)
  Fix interpolations with repeated vars
  readme [ci skip]
  changelog
  s/inconsistent_interpolation/inconsistent_interpolations
  Bump to v0.9.26
  s/Commands::Inconsistent/Commands::Interpolations/
  DeeplTranslator: Fix CommandError
  Follow-up to glebm#304
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants