Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test against the latest ruby #298

Merged
merged 6 commits into from
Sep 13, 2018
Merged

Test against the latest ruby #298

merged 6 commits into from
Sep 13, 2018

Conversation

deivid-rodriguez
Copy link
Contributor

Maybe you should actually add all supported major rubies in here?

@deivid-rodriguez
Copy link
Contributor Author

I also observed that you use TargetRubyVersion: 2.3 in .rubocop.yml, but required_ruby_version = '~> 2.1' in gemspec. This is dangerous because you might accidentally break support by using newer rubies features, specially since you don't test all versions. You should probably reconcile that too.

@deivid-rodriguez
Copy link
Contributor Author

Any thoughts here @glebm? I'll gladly make the extra changes I commented if you agree with them!

@glebm
Copy link
Owner

glebm commented Sep 13, 2018

Sounds good to me and let's remove support for older rubies. https://www.ruby-lang.org/en/news/2018/06/20/support-of-ruby-2-2-has-ended/

@deivid-rodriguez
Copy link
Contributor Author

Absolutely, let me add those changes!

@deivid-rodriguez
Copy link
Contributor Author

It's ready, have a look! I also fixed some TODO's were meant to be fixed after dropping 2.2 support. I fully trusted rubocop auto-correction here (plus manually fixed the non-autocorrectable Style/NumericPredicate offenses. I looked at the generated diff and looks correct to me?

@deivid-rodriguez
Copy link
Contributor Author

Also, I didn't touch the changelog because I noticed that you normally update it at relase time.

@glebm glebm merged commit 3582b9a into glebm:master Sep 13, 2018
@deivid-rodriguez deivid-rodriguez deleted the bump_rubies branch September 13, 2018 16:52
@glebm glebm added this to the v0.9.25 milestone Sep 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.9.25
Development

Successfully merging this pull request may close these issues.
2 participants
@deivid-rodriguez @glebm