using %{key} in add_missing interpolations #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Of course, if you add this options to the main repo, I'll be happy to extend the current documentation ;) |
glebm
added a commit
that referenced
this pull request
Aug 7, 2015
using %{key} in add_missing interpolations
|
@stijnster Thank you for your contribution! 👍 |
|
Release in v0.8.7! Docs updated |
|
Awseome stuff! Thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
thanks for your awesome work on this gem.
When using it, we noticed that using the "human_key" is not always optimal for us. So I've added the ability to add a "%{key}" value which will add the node's full_key in the interpolated value.
I've added tests for this new feature and they all turn green.
Please consider this feature to add to the main repository.
Kind regards,
Stijn