Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow relative locales in controllers #113

Merged
merged 1 commit into from
Dec 17, 2014
Merged

Allow relative locales in controllers #113

merged 1 commit into from
Dec 17, 2014

Conversation

jessieay
Copy link
Collaborator

  • Update absolutize method to set controller locales
  • Fixes relative keys in controller actions #46
  • There is one failing spec that I could not figure out. Put a "TODO" comment above it and commented it out. Would appreciate help debugging! Failure output:
1) i18n-tasks missing detects missing
     Failure/Error: expect(run_cmd :missing).to be_i18n_keys expected_missing_keys
       Expected ["en.events.show.success", "en.fn_comment", "en.hash.pattern_missing.a", "en.hash.pattern_missing.b", "en.missing-key-question?.key", "en.missing-key-with-a-dash.key", "en.missing_symbol.key_three", "en.missing_symbol.key_two", "en.missing_symbol_key", "en.only_in_es", "en.present_in_es_but_not_en.a", "en.used_but_missing.key", "es.missing_in_es.a", "es.missing_in_es_plural_1.a", "es.missing_in_es_plural_2.a"], but had ["en..Users.jessieayoung.dev.jessieay.i18n-tasks.tmp.test_codebase.app.views.relative.index.description", "en..Users.jessieayoung.dev.jessieay.i18n-tasks.tmp.test_codebase.app.views.relative.index.missing", "en..Users.jessieayoung.dev.jessieay.i18n-tasks.tmp.test_codebase.app.views.relative.index.summary", "en..Users.jessieayoung.dev.jessieay.i18n-tasks.tmp.test_codebase.app.views.relative.index.title", "en.events.show.success", "en.fn_comment", "en.hash.pattern_missing.a", "en.hash.pattern_missing.b", "en.missing-key-question?.key", "en.missing-key-with-a-dash.key", "en.missing_symbol.key_three", "en.missing_symbol.key_two", "en.missing_symbol_key", "en.only_in_es", "en.present_in_es_but_not_en.a", "en.used_but_missing.key", "es.missing_in_es.a", "es.missing_in_es_plural_1.a", "es.missing_in_es_plural_2.a"]. Diff:

       missing: []
       extra:   ["en..Users.jessieayoung.dev.jessieay.i18n-tasks.tmp.test_codebase.app.views.relative.index.description", "en..Users.jessieayoung.dev.jessieay.i18n-tasks.tmp.test_codebase.app.views.relative.index.missing", "en..Users.jessieayoung.dev.jessieay.i18n-tasks.tmp.test_codebase.app.views.relative.index.summary", "en..Users.jessieayoung.dev.jessieay.i18n-tasks.tmp.test_codebase.app.views.relative.index.title"]

@jessieay jessieay changed the title Allow relative roots in controllers Allow relative locales in controllers Dec 17, 2014
* Update `absolutize` method to set controller locales
* Fixes #46
@glebm glebm merged commit 9349168 into glebm:master Dec 17, 2014
glebm added a commit that referenced this pull request Dec 17, 2014
@glebm
Copy link
Owner

glebm commented Dec 17, 2014

This is great, thank you! 👍 I've fixed a minor issues and the tests.

@glebm
Copy link
Owner

glebm commented Dec 18, 2014

Released in v0.7.9 🚢

@glebm
Copy link
Owner

glebm commented Dec 18, 2014

I've added you to Collaborators 🌟

@jessieay
Copy link
Collaborator Author

@glebm 🙌

@c-lliope
Copy link

@jessieay you're the best! Just upgraded a client project for this. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

relative keys in controller actions
3 participants