Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad matching in with not EN native app #526

Closed
lefermierperso opened this issue Oct 10, 2023 · 0 comments · Fixed by #529
Closed

Bad matching in with not EN native app #526

lefermierperso opened this issue Oct 10, 2023 · 0 comments · Fixed by #529

Comments

@lefermierperso
Copy link

lefermierperso commented Oct 10, 2023 •
edited
Loading

in a slim :
| À bientôt !
running 'i18n-tasks missing fr'
't !' is catch by patten_matcher regex /(?<=^|[^\w'\-.]|[^\w'-]I18n.|I18n.)t(?:!|ranslate!?)?/
the problem is \w does not trigger unicode char like ô
@lefermierperso lefermierperso changed the title Bad matching in with none EN native app Bad matching in with not EN native app Oct 10, 2023
@davidwessman davidwessman mentioned this issue Oct 21, 2023
Merged
davidwessman added a commit to davidwessman/i18n-tasks that referenced this issue Oct 21, 2023
@davidwessman
PatternScanner: Handles non \w characters
067f0cd 
- Fixes glebm#526
glebm pushed a commit that referenced this issue Oct 23, 2023
@davidwessman @glebm
PatternScanner: Handles non \w characters
e939d0e 
- Fixes #526
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

PatternScanner: Handles non \w characters davidwessman/i18n-tasks
1 participant
@lefermierperso