Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mist module split #87

Merged
merged 3 commits into from
Jul 25, 2024
Merged

Mist module split #87

merged 3 commits into from
Jul 25, 2024

Conversation

bgwdotdev
Copy link
Contributor

Preceding pr #72 and comment: #72 (review)

This is just the split of the existing mist functions and code from the main wisp module.

An internal module has been added to allow code share between wisp and any web server implementation such as mist.

Mist has been entirely removed from the main wisp.gleam and wisp/internal.gleam files.

Copy link
Collaborator

@lpil lpil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely work! Thank you

@lpil
Copy link
Collaborator

lpil commented Jul 25, 2024

Ah! The tests have failed!

@bgwdotdev
Copy link
Contributor Author

Oh sorry! Missed updating 02. Updated that and re-ran everything and seem to be good again :)!

@lpil
Copy link
Collaborator

lpil commented Jul 25, 2024

Thank you!

@lpil lpil merged commit 7ce8979 into gleam-wisp:main Jul 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants