Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add set.each function #718

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Add set.each function #718

merged 2 commits into from
Oct 30, 2024

Conversation

mpatajac
Copy link
Contributor

Found myself needing this while working on a project, saw that list and dict had equivalent functions, so I thought it would be nice if set had one too.

Implementation, documentation and test adapted from the list and dict equivalents.

lpil
lpil reviewed Oct 30, 2024
View reviewed changes
Copy link
Member

@lpil lpil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks! Couple tiny notes inline

src/gleam/set.gleam Outdated Show resolved Hide resolved
test/gleam/set_test.gleam Outdated Show resolved Hide resolved
lpil
lpil approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@lpil lpil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you again!

@mpatajac
Copy link
Contributor Author

Thanks, the suggestions definitely make more sense.

@lpil lpil merged commit 75d5165 into gleam-lang:main Oct 30, 2024
7 checks passed
@mpatajac mpatajac deleted the set-each branch October 30, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpil lpil lpil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mpatajac @lpil