Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove need for reverse in list.range #487

Merged
merged 1 commit into from
Aug 25, 2023
Merged

Remove need for reverse in list.range #487

merged 1 commit into from
Aug 25, 2023

Conversation

vonagam
Copy link
Contributor

@vonagam vonagam commented Aug 24, 2023

If items collected into a list going not from the start but from the end then there is no need to call reverse.

lpil
lpil approved these changes Aug 25, 2023
View reviewed changes
Copy link
Member

@lpil lpil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh this this smart! Thank you 💜

@lpil lpil merged commit 8ab8308 into gleam-lang:main Aug 25, 2023
1 check passed
@vonagam vonagam deleted the remove-list-range-reversal branch August 25, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpil lpil lpil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vonagam @lpil