Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate shorthand target names #3851

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Deprecate shorthand target names #3851

wants to merge 3 commits into from
+161 −9

Conversation

GearsDatapacks
Copy link
Member

Closes #3826

lpil
lpil reviewed Nov 19, 2024
View reviewed changes
Copy link
Member

@lpil lpil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment inline. Thank you!

compiler-core/src/warning.rs Outdated
@@ -201,6 +201,11 @@ pub enum DeprecatedSyntaxWarning {
/// ```
///
DeprecatedRecordSpreadPattern { location: SrcSpan },

DeprecatedTargetShorthand {
full_name: &'static str,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be target: Target as it's always one of those two values

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpil lpil lpil left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Small inconsistency in target strings
2 participants
@GearsDatapacks @lpil