Specs for MicroEvent #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't like all those occurrences of expect(event_funcs.foo.calls.length).toEqual(1); but right now I don't know an easy way to solve this, so I'll postpone working on this for now.
Moving spyOn()-calls to beforeEach() to get specs with less noise
|
the MicroEvent is actually an external library from https://github.com/jeromeetienne/microevent.js. I just saw now that the lib file is missing an origin. I do not think that we should have tests for that library. Though I am pretty sure that the owner of the original library will be more than happy about a pull request from you. |
|
Noooooooooooooooooooooooooooooooooooooooooo! :S |
|
I am really sorry about this. The file was added in a hurry because we needed some sort of event dispatcher and at the time it seemed logical for everyone to find external libraries in lib/ |
|
Well, let's see if it gets accepted by the original author. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spec'ed MicroEvent.
Mixin specs will come in another pull request in the next days.
Huh, why the heck are there those merge-commits appearing in this pull request?