fix: use max version instead of latest for package update check

Signed-off-by: Jakob Steiner <[email protected]>

src/commands/package/index.ts

@@ -7,8 +7,8 @@ import {getLatestRelease} from '../../datasources/github-release/index.js';
 import {
   copyUnmanagedFiles,
   createNewManifestVersion,
-  getLatestManifest,
-  getLatestVersion,
+  getMaxVersion,
+  getMaxVersionManifest,
   updateHelmManifest,
 } from '../../manifest.js';
 import {ManifestUrl} from '../../models/manifest-url.js';
@@ -42,10 +42,10 @@ export default class Package extends Command {
   public async run(): Promise<void> {
     const {flags} = await this.parse(Package);
     const packagePaths = this.paths.package(flags.name);
-    const packageManifest = await getLatestManifest(packagePaths);
+    const packageManifest = await getMaxVersionManifest(packagePaths);
 
     let newPackageManifestAvailable = false;
-    const currentAppVersion = await getLatestVersion(packagePaths);
+    const currentAppVersion = await getMaxVersion(packagePaths);
     let newAppVersion = currentAppVersion;
 
     if (packageManifest.helm) {

src/manifest.ts

@@ -4,7 +4,7 @@ import {SemVer} from 'semver';
 import * as YAML from 'yaml';
 
 import {getPackageVersions} from './package.js';
-import {PackagePaths, PackageVersionPaths} from './paths.js';
+import {ManifestYaml, PackagePaths, PackageVersionPaths} from './paths.js';
 import {ArtifactHubPackage, PackageManifest} from './types/types.js';
 import {createDir, getFilesIn, parseYaml, read, write} from './utils/io.js';
 
@@ -59,15 +59,32 @@ export async function updateLatestVersion(paths: PackagePaths): Promise<boolean>
   return false;
 }
 
-export async function getLatestVersion(paths: PackagePaths) {
+export async function getLatestVersion(paths: PackagePaths): Promise<SemVer> {
   const packageVersions = await getPackageVersions(paths);
   return new SemVer(packageVersions.latestVersion);
 }
 
+export async function getMaxVersion(paths: PackagePaths): Promise<SemVer> {
+  const versions = (await getPackageVersions(paths)).versions.map(it => new SemVer(it.version));
+  versions.sort((a, b) => a.compare(b));
+  const maxVersion = versions.at(-1);
+  if (maxVersion) {
+    return maxVersion;
+  }
+
+  throw new Error('versions must not be empty');
+}
+
+export async function getManifest(paths: ManifestYaml) {
+  return parseYaml<PackageManifest>(await read(paths.packageYaml()));
+}
+
 export async function getLatestManifest(paths: PackagePaths) {
-  const latestVersion = await getLatestVersion(paths);
-  const stringContent = await read(paths.version(latestVersion.raw).packageYaml());
-  return parseYaml<PackageManifest>(stringContent);
+  return getManifest(paths.version((await getLatestVersion(paths)).raw));
+}
+
+export async function getMaxVersionManifest(paths: PackagePaths) {
+  return getManifest(paths.version((await getMaxVersion(paths)).raw));
 }
 
 export function updateHelmManifest(packageData: PackageManifest, artifactHubData: ArtifactHubPackage) {

src/paths.ts

@@ -3,8 +3,8 @@ import path from 'node:path';
 type StringSupplier = () => string;
 type DirName = {readonly dirName: StringSupplier};
 type IndexYaml = {readonly indexYaml: StringSupplier};
-type VersionsYaml = {readonly versionsYaml: StringSupplier};
-type ManifestYaml = {readonly packageYaml: StringSupplier};
+export type VersionsYaml = {readonly versionsYaml: StringSupplier};
+export type ManifestYaml = {readonly packageYaml: StringSupplier};
 export type PackageVersionPaths = DirName & ManifestYaml;
 type WithPackageVersion = {readonly version: (version: string) => PackageVersionPaths};
 export type PackagePaths = DirName & ManifestYaml & VersionsYaml & WithPackageVersion;