Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable binary decoding. #80

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Enable binary decoding. #80

wants to merge 4 commits into from

Commits on Mar 31, 2019

  1. Enable binary decoding.

    There are a lot of fiddly details about transiting between different
    data encodings. And the QR spec is a bit vague on some parts.
    I've detailed the problems at the sister project
    zxing-cpp/zxing-cpp#62
    
    I've decided to patch this in a works-for-me kind of way:
    unmarked encodings are treated as bianry and if that's not
    good enough the higher layers have the source material
    and can try decoding it themselves.
    kousu committed Mar 31, 2019
    Configuration menu
    Copy the full SHA
    e85f221 View commit details
    Browse the repository at this point in the history
  2. Test binary data decoding

    kousu committed Mar 31, 2019
    Configuration menu
    Copy the full SHA
    d6266b0 View commit details
    Browse the repository at this point in the history
  3. Tidy tests

    kousu committed Mar 31, 2019
    Configuration menu
    Copy the full SHA
    cf29c47 View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2019

  1. Regenerate expected test output

    I think I'd generated my expected output from zxing itself.
    This was generated from the source file with
    curl https://sampleswap.org//samples-ghost/DRUM%20LOOPS%20and%20BREAKS/161%20to%20180%20bpm/128[kb]161_amenvar3.aif.mp3 | head -c 856 | tee ../tests/amen-01.bin
    856 is the packet size qrencode decided to chunk this file into when I first split it up.
    kousu committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    a306fe9 View commit details
    Browse the repository at this point in the history