New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build system tweaks #62

Open

SyrianSpock wants to merge 3 commits into glassechidna:master from SyrianSpock:master

SyrianSpock commented Feb 5, 2018

This PR fixes a few issues I encountered while building the library:

Find optional libraries is turned to quiet, so if OpenCV or Iconv are not detected the respective modules are not built silently. Previously it would fail the compilation.
Build libzxing as a shared library, makes it easier to link against shared library (no need to build in PIC mode).
Symbols are exported correctly when compiling on Windows MSVC2017.

SyrianSpock added 3 commits

February 5, 2018 10:01


          Quiet find optional libraries OpenCV/Iconv

156e945


          Append suffix to library only when built in Debug mode

2013ea0


          Export symbols to compile correctly on Windows

f33dc09

kousu mentioned this pull request

Darwin build #76

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet