Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidy up typing #355

Closed
paddyroddy opened this issue Oct 14, 2024 · 0 comments · Fixed by #356
Closed

Tidy up typing #355

paddyroddy opened this issue Oct 14, 2024 · 0 comments · Fixed by #356
Assignees
@paddyroddy
Labels
enhancement New feature or request maintenance Maintenance: refactoring, typos, etc.

Comments

@paddyroddy
Copy link
Member

Is Your Feature Request Related to a Problem? Please Describe

Going to consistently apply typing imports throughout. Simplifying the #308 PR.

Describe the Solution You'd Like

No response

Describe Alternatives You've Considered

No response

Additional Context

No response
@paddyroddy paddyroddy added enhancement New feature or request maintenance Maintenance: refactoring, typos, etc. labels Oct 14, 2024
@paddyroddy paddyroddy self-assigned this Oct 14, 2024
paddyroddy added a commit that referenced this issue Oct 14, 2024
@paddyroddy
gh-355: consistent use of typing and collections.abc
60a328d 
Fixes #355, simplifying #308. Change all import of
`typing`/`collections.abc` to `import <x>` rather than
`from <x> import` syntax. This is useful because it is straightforward
to see at a glance where the `import` is coming from. Further, we have
both `numpy.random.Generator` and `collections.abc.Generator` in use -
so it separates them. I've also moved everything out of the
`TYPE_CHECKING` block, except from where `ruff` says we should.
@paddyroddy paddyroddy mentioned this issue Oct 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paddyroddy paddyroddy

Labels
enhancement New feature or request maintenance Maintenance: refactoring, typos, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gh-355: consistent use of typing and collections.abc glass-dev/glass
1 participant
@paddyroddy