Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Run button to PALS Viewer #24

Open
joewandy opened this issue Apr 8, 2020 · 5 comments
Open

Add a Run button to PALS Viewer #24

joewandy opened this issue Apr 8, 2020 · 5 comments
Assignees
Labels
enhancement New feature or request manuscript

Comments

@joewandy
Copy link
Member

joewandy commented Apr 8, 2020

Add a Run button instead of running pathway analysis automatically in PALS Viewer.

A bit messy to do because of: https://discuss.streamlit.io/t/programmable-state-for-streamlit/2052

Right now, getting a Streamlit app to store internal state, like information a user entered in a form, is simply too tricky. There are some workarounds 23 for session state 11, but we want to give you a baked-in and elegant version of programmable state so you can build apps with sequential logic, apps with multiple pages, apps that incrementally ask users for input, and so on. Please share thoughts here 21 about the use cases you’d like to see supported.

There are hacky ways to do it, or maybe it's best to wait until they fix it properly.

@joewandy joewandy added the enhancement New feature or request label Apr 8, 2020
@joewandy joewandy self-assigned this Apr 8, 2020
@joewandy
Copy link
Member Author

joewandy added a commit that referenced this issue May 1, 2020
@joewandy
Copy link
Member Author

joewandy commented May 1, 2020

Implemented the workaround based on the link above.

@joewandy joewandy closed this as completed May 1, 2020
@joewandy
Copy link
Member Author

joewandy commented May 5, 2020

The workaround above seems buggy. Reopening this issue to fix it properly.

@joewandy joewandy reopened this May 5, 2020
@joewandy
Copy link
Member Author

joewandy commented May 6, 2020

Would be good if we also add a Load Example Data button for reviewers.

@joewandy
Copy link
Member Author

joewandy commented May 15, 2020

Seems like there's a bug if we try to run multiple analyses several times. The metadata from the previous one is still kept around, and users haven't had a chance to change it yet. This won't happen if we have a Run button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request manuscript
Projects
None yet
Development

No branches or pull requests

1 participant