Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Longhorn storage provider for Vault #81

Merged
merged 4 commits into from
Dec 5, 2024

Conversation

matthewrossi
Copy link
Member

Here is a summary of the changes:

  • Use Longhorn for the provisioning of Persistent Volumes in Vault and MinIO tenants instead of the only option previously available (i.e., Local Path Provisioner)
  • Remove the unused Local Path Provisioner

@matthewrossi matthewrossi self-assigned this Dec 2, 2024
@matthewrossi matthewrossi requested a review from a team as a code owner December 2, 2024 13:13
@matthewrossi matthewrossi changed the title Use Longhorn storage provider Use Longhorn storage provider for all services Dec 2, 2024
@ktatarnikovhiro
Copy link
Contributor

Why is this necessary? what is rationale behind this?

Copy link
Contributor

@ktatarnikovhiro ktatarnikovhiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this necessary? what is rationale behind this?

@matthewrossi
Copy link
Member Author

Looking at the current cluster state, every service except ours are using Longhorn. So, the rationale is mainly to simplify the deployment by avoiding the use of two storage classes and their relative controller services.

Also according to a comment by a maintainer of both projects, the use of the Local Path Provisioner introduces restrictions in the scheduling of Kubernetes workloads and, overall, it lacks features like HA across the cluster, snapshot, backup, etc.

@ktatarnikovhiro
Copy link
Contributor

You mentioned only theoretical arguments. Is there any technical rationale behind that?

If no, I'd rather keep minio running over local provisioner since longhorn is another level of unnecessary replication and complexity.
Minio is designed to run over local volumes and has erasure coding to handle replication failures. Running minio over longhorn is not recommended.

@ktatarnikovhiro
Copy link
Contributor

For the vault and other things it is fine to use longhorn.

@matthewrossi
Copy link
Member Author

Beside what previously mentioned, it may be that the scheduling restrictions of the Local Path Provisioner interfere with the AI-decision engine, but admittedly this is purely hypothetical.

In light of your considerations, I guess we can keep MinIO on the Local Path Provisioner, and move only Vault to the use of Longhorn.

@matthewrossi matthewrossi changed the title Use Longhorn storage provider for all services Use Longhorn storage provider for ~~all services~~ Vault Dec 4, 2024
@matthewrossi matthewrossi changed the title Use Longhorn storage provider for ~~all services~~ Vault Use Longhorn storage provider for ~all services~ Vault Dec 4, 2024
@matthewrossi matthewrossi changed the title Use Longhorn storage provider for ~all services~ Vault Use Longhorn storage provider for Vault Dec 4, 2024
@a-zharinov a-zharinov merged commit 6eccbaf into fix/kustomization Dec 5, 2024
@matthewrossi matthewrossi deleted the feature/remove-local-path-storage branch December 10, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants